Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics,client-go: update client-go and add batch client receive response metrics #27688

Merged
merged 11 commits into from
Oct 13, 2021

Conversation

tiancaiamao
Copy link
Contributor

Signed-off-by: tiancaiamao tiancaiamao@gmail.com

What problem does this PR solve?

Cherry pick #27583

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix a batch client bug that recycle idle connection may block sending requests in some rare cases.

…onse metrics

Signed-off-by: tiancaiamao <tiancaiamao@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 31, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • djshow832

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 31, 2021
@tiancaiamao tiancaiamao added needs-cherry-pick-release-5.2 affects-5.2 This bug affects 5.2.x versions. type/bugfix This PR fixes a bug. type/5.2-cherry-pick and removed affects-5.2 This bug affects 5.2.x versions. needs-cherry-pick-release-5.2 labels Aug 31, 2021
@disksing
Copy link
Contributor

Hi @tiancaiamao , I have created a tidb-5.2 branch in client-go. I suggest we do some cherry-pick in client-go side and use tidb-5.2 branch to avoid other changes in master branch introducing some new bugs.

@tiancaiamao
Copy link
Contributor Author

Hi @tiancaiamao , I have created a tidb-5.2 branch in client-go. I suggest we do some cherry-pick in client-go side and use tidb-5.2 branch to avoid other changes in master branch introducing some new bugs.

OK, I can update this branch

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2021
@tiancaiamao
Copy link
Contributor Author

PTAL @crazycs520 @djshow832

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 7, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 13, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c621ad6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2021
@ti-chi-bot
Copy link
Member

@tiancaiamao: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 048002d into pingcap:release-5.2 Oct 13, 2021
@zhouqiang-cl zhouqiang-cl added this to the v5.2.2 milestone Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.2-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants